Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/default_session_overwrite #54

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 3, 2023

reserve "default" session for core

reserve "default" session for core
@JarbasAl JarbasAl added the bug Something isn't working label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ca7519b) 53.63% compared to head (4ef8192) 53.53%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #54      +/-   ##
==========================================
- Coverage   53.63%   53.53%   -0.10%     
==========================================
  Files          14       14              
  Lines        1072     1074       +2     
==========================================
  Hits          575      575              
- Misses        497      499       +2     
Files Coverage Δ
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/session.py 55.55% <0.00%> (-0.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 8dfaecd into dev Oct 3, 2023
6 of 7 checks passed
@JarbasAl JarbasAl deleted the fix/default_session_overwrite branch October 3, 2023 20:51
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant